Skip to content

implement EIP-234: add blockHash param for eth_getLogs #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gzliudan merged 1 commit into from
Mar 14, 2024
Merged

implement EIP-234: add blockHash param for eth_getLogs #490

gzliudan merged 1 commit into from
Mar 14, 2024

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Mar 13, 2024 •
edited
Loading

Proposed changes

This PR fix #457 by support parameter blockHash in the input of method eth_getLogs.

Notice: this function is removed by PR #131.

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Test

request:

curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc": "2.0",
  "id": 6003,
  "method": "eth_getLogs",
  "params": [
    {
      "blockHash": "'"${HASH}"'"
    }
  ]
}' | jq

response:

{
  "jsonrpc": "2.0",
  "id": 6003,
  "result": [
    {
      "address": "0x0000000000000000000000000000000000000089",
      "topics": [
        "0x62855fa22e051687c32ac285857751f6d3f2c100c72756d8d30cb7ecb1f64f54"
      ],
      "data": "0x00000000000000000000000096509a56f0243b10a2706391b95af449712da69900000000000000000000000000000000000000000000000000000000000005dcce1d2eca75e10aeea5edf82ac30b24d226881a4e6eae4b89120b73978862aa9c",
      "blockNumber": "0x5de",
      "transactionHash": "0x7f58b867d33756af9a5d42eba7955f943a99a05516da672a77210300152b08ce",
      "transactionIndex": "0x0",
      "blockHash": "0xd56a4b9835ad8067cf87e29d1a12437369fb4a4bd1a5b5cf5d538e7fd34806e4",
      "logIndex": "0x0",
      "removed": false
    },
    {
      "address": "0x0000000000000000000000000000000000000089",
      "topics": [
        "0x62855fa22e051687c32ac285857751f6d3f2c100c72756d8d30cb7ecb1f64f54"
      ],
      "data": "0x0000000000000000000000002526fdebae27162e45da84e5e2f00abaa1a1cc8c00000000000000000000000000000000000000000000000000000000000005dcce1d2eca75e10aeea5edf82ac30b24d226881a4e6eae4b89120b73978862aa9c",
      "blockNumber": "0x5de",
      "transactionHash": "0x729eb00a6f54f1fb7aaf6f012b6b57b263f820a2b3b6781b42a6c84314171a8c",
      "transactionIndex": "0x1",
      "blockHash": "0xd56a4b9835ad8067cf87e29d1a12437369fb4a4bd1a5b5cf5d538e7fd34806e4",
      "logIndex": "0x1",
      "removed": false
    }
  ]
}

request:

curl -s -X POST -H "Content-Type: application/json" ${RPC} -d '{
   "jsonrpc": "2.0",
   "id": 6003,
   "method": "eth_getLogs",
   "params": [
     {
       "fromBlock": "0x1",
       "toBlock": "0xf"
     },
     {
       "blockHash": "'"${HASH}"'"
     }
   ]
}' | jq

response:

{
  "jsonrpc": "2.0",
  "id": 6003,
  "error": {
    "code": -32602,
    "message": "too many arguments, want at most 1"
  }
}

request:

curl -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc":"2.0",
  "id": 6002,
  "method":"eth_getLogs",
  "params":[
    {
      "fromBlock": "0x1",
      "toBlock": "0xff",
      "topics": [
        "0x000000000000000000000000a94f5374fce5edbc8e2a8697c15331677e6ebf0b"
      ]
    }
  ]
}' | jq

response:

{
  "jsonrpc": "2.0",
  "id": 6002,
  "result": []
}

request:

curl -X POST -H "Content-Type: application/json" ${RPC} -d '{
  "jsonrpc":"2.0",
  "id": 6002,
  "method":"eth_getLogs",
  "params":[
    {
      "fromBlock": "0x1",
      "toBlock": "0x10"
    }
  ]
}' | jq

response

{
  "jsonrpc": "2.0",
  "id": 6002,
  "result": [
    {
      "address": "0x0000000000000000000000000000000000000089",
      "topics": [
        "0x62855fa22e051687c32ac285857751f6d3f2c100c72756d8d30cb7ecb1f64f54"
      ],
      "data": "0x0000000000000000000000002526fdebae27162e45da84e5e2f00abaa1a1cc8c000000000000000000000000000000000000000000000000000000000000000f4027ffb371d54b5c072b618a00724fda5907ff324e557f3be50102502597a60e",
      "blockNumber": "0x10",
      "transactionHash": "0xdea69962667164bfa0a76d2678c0dc9f9a3d7226a8c59e9d6a4ba3796f219067",
      "transactionIndex": "0x0",
      "blockHash": "0x07745cd6967cd94bd401bbdfe4b44f6b3953ff11e1a59bc284dc466647f044db",
      "logIndex": "0x0",
      "removed": false
    },
    {
      "address": "0x0000000000000000000000000000000000000089",
      "topics": [
        "0x62855fa22e051687c32ac285857751f6d3f2c100c72756d8d30cb7ecb1f64f54"
      ],
      "data": "0x00000000000000000000000096509a56f0243b10a2706391b95af449712da699000000000000000000000000000000000000000000000000000000000000000f4027ffb371d54b5c072b618a00724fda5907ff324e557f3be50102502597a60e",
      "blockNumber": "0x10",
      "transactionHash": "0x0ac0dca577b9dc3bd06e7f58dc55225178b8da24920ebfec6f17916268165ea9",
      "transactionIndex": "0x1",
      "blockHash": "0x07745cd6967cd94bd401bbdfe4b44f6b3953ff11e1a59bc284dc466647f044db",
      "logIndex": "0x1",
      "removed": false
    },
    {
      "address": "0x0000000000000000000000000000000000000089",
      "topics": [
        "0x62855fa22e051687c32ac285857751f6d3f2c100c72756d8d30cb7ecb1f64f54"
      ],
      "data": "0x00000000000000000000000077cb85ae0ae070dfc013ba1a5b3ee1ced4a059a7000000000000000000000000000000000000000000000000000000000000000f4027ffb371d54b5c072b618a00724fda5907ff324e557f3be50102502597a60e",
      "blockNumber": "0x10",
      "transactionHash": "0x148c22e50bd86b8109679b6e0c51be5dbd2813e8779c2fafcd25fb198e6183f9",
      "transactionIndex": "0x2",
      "blockHash": "0x07745cd6967cd94bd401bbdfe4b44f6b3953ff11e1a59bc284dc466647f044db",
      "logIndex": "0x2",
      "removed": false
    }
  ]
}

liam-lai
liam-lai reviewed Mar 13, 2024
View reviewed changes
liam-lai
liam-lai reviewed Mar 13, 2024
View reviewed changes
@gzliudan gzliudan requested a review from liam-lai March 13, 2024 13:16
@gzliudan gzliudan merged commit 4938ba7 into XinFinOrg:dev-upgrade Mar 14, 2024
@gzliudan gzliudan deleted the eip234 branch March 14, 2024 04:06
@gzliudan gzliudan mentioned this pull request Mar 19, 2024
Closed
@liam-lai liam-lai mentioned this pull request Mar 20, 2024
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liam-lai liam-lai liam-lai approved these changes

@wjrjerome wjrjerome Awaiting requested review from wjrjerome

@wgr523 wgr523 Awaiting requested review from wgr523

@AnilChinchawale AnilChinchawale Awaiting requested review from AnilChinchawale

@GalaxySciTech GalaxySciTech Awaiting requested review from GalaxySciTech

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gzliudan @liam-lai @reductionista